Skip to content

rpm: adjust SELinux snippets for relabeling #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

rpm: adjust SELinux snippets for relabeling #184

merged 1 commit into from
Jan 4, 2025

Conversation

@marmarek
Copy link
Member

Adjust according to https://fedoraproject.org/wiki/SELinux/IndependentPolicy#Creating_the_Spec_File

Specifically, when %selinux_relabel_post is used, %selinux_relabel_pre
needs to be there too.

QubesOS/qubes-issues#9663

@marmarek
rpm: adjust SELinux snippets for relabeling
6077a10 
Adjust according to https://fedoraproject.org/wiki/SELinux/IndependentPolicy#Creating_the_Spec_File

Specifically, when %selinux_relabel_post is used, %selinux_relabel_pre
needs to be there too.

QubesOS/qubes-issues#9663
@qubesos-bot
Copy link

qubesos-bot commented Dec 24, 2024 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025010322-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

  • system_tests_network_updates

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_30_Gui_daemon: test_000_clipboard (error)
      FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...

    • TC_30_Gui_daemon: test_002_clipboard_300k (failure)
      : Clipboard copy operation failed - content...

Failed tests

5 failures

  • system_tests_network_updates

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_basic_vm_qrexec_gui_zfs

    • TC_30_Gui_daemon: test_000_clipboard (error)
      FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...

    • TC_30_Gui_daemon: test_002_clipboard_300k (failure)
      : Clipboard copy operation failed - content...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

3 fixed

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

  • system_tests_basic_vm_qrexec_gui_zfs

    • switch_pool: Failed (test died)
      # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...

  • system_tests_audio@hw1

Unstable tests

  • system_tests_update

    update2/Failed (1/5 times with errors)
    • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

  • system_tests_update@hw1

    update2/Failed (1/5 times with errors)
    • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

  • system_tests_update@hw7

    update2/Failed (1/5 times with errors)
    • job 121711 # Test died: command '(set -o pipefail; qubesctl --show-output stat...

This was referenced Dec 24, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.17%. Comparing base (0e35fa4) to head (6077a10).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   79.13%   79.17%   +0.04%     
==========================================
  Files          54       54              
  Lines        9953     9953              
==========================================
+ Hits         7876     7880       +4     
+ Misses       2077     2073       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Dec 27, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 4, 2025
Merged
Merged
@marmarek marmarek merged commit 6077a10 into QubesOS:main Jan 4, 2025
4 of 5 checks passed
@marmarek marmarek mentioned this pull request Jan 4, 2025
Merged
@marmarek marmarek deleted the selinux-pre branch February 18, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

openqa-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marmarek @qubesos-bot